Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant md.backup file by update-reference-docs.sh #5417

Closed
JeromeJu opened this issue Sep 1, 2022 · 6 comments
Closed

Redundant md.backup file by update-reference-docs.sh #5417

JeromeJu opened this issue Sep 1, 2022 · 6 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@JeromeJu
Copy link
Member

JeromeJu commented Sep 1, 2022

Expected Behavior

The ./hack/update-reference-docs.sh script should have deleted the pipeline.md.backup file once the script is done.

Actual Behavior

There is a redundant pipeline.md.backup file generated.

Steps to Reproduce the Problem

  1. Currently occurred in go1.19 darwin/arm64 and go1.19 linux/amd64 when running ./hack/update-reference-docs.sh

Related PR: #5324

Additional Info

  • Kubernetes version:
Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.1", GitCommit:"3ddd0f45aa91e2f30c70734b175631bec5b5825a", GitTreeState:"clean", BuildDate:"2022-05-24T12:26:19Z", GoVersion:"go1.18.2", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v4.5.4
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.13-gke.900", GitCommit:"8f8dd9d389916c66dd26704a96f1ab4c5776f9df", GitTreeState:"clean", BuildDate:"2022-06-06T09:24:36Z", GoVersion:"go1.16.15b7", Compiler:"gc", Platform:"linux/amd64"}
  • Tekton Pipeline version:
Client version: 0.24.0
Pipeline version: devel

Looping in @vsinghai for visibility.

@JeromeJu JeromeJu added the kind/bug Categorizes issue or PR as related to a bug. label Sep 1, 2022
@JeromeJu JeromeJu changed the title Redundant md.backup file by ./hack/update-reference-docs.sh Redundant md.backup file by ./hack/update-reference-docs.sh Sep 1, 2022
@JeromeJu JeromeJu changed the title Redundant md.backup file by ./hack/update-reference-docs.sh Redundant md.backup file by update-reference-docs.sh Sep 1, 2022
@abayer
Copy link
Contributor

abayer commented Sep 1, 2022

This file is being generated as a result of 8381d0d

This was done to make the sed call work on Macs. I have gsed aliased to sed on my Mac, so I didn't hit whatever the problem was on Macs myself when setting this up. I'm not sure if/how one would call sed to not create a backup file, because sed has always been a mystery to me. =)

@dibyom
Copy link
Member

dibyom commented Sep 1, 2022

maybe we just rm the .backup file once we are done?

@dibyom
Copy link
Member

dibyom commented Sep 1, 2022

or just add it to the .gitignore :)

@abayer
Copy link
Contributor

abayer commented Sep 1, 2022

heehee. =)

@vsinghai
Copy link
Contributor

vsinghai commented Sep 2, 2022

I believe this issue was solved in #5418 and can be closed now, thanks @JeromeJu!

@abayer
Copy link
Contributor

abayer commented Sep 2, 2022

Yup, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants