Question: How/when to remove NGSI-v1 from the library?

[jason-fox]

I know NGSI-v1 is deprecated, but at some point I assume NGSI-v1 support is to be dropped. Just to ensure things don't get lost here is a reminder for future development:

1. Delete NGSI-v1 modules refactored out by Adding NGSI-LD support #842
2. Delete NGSI-v1 unit tests - look for prefix NGSI-v1
3. Look for instances of isCurrentNgsi() across current IoT Agent codebases - see Mixed mode implementation breaks the code of the IOTAs using iotagent-node-lib #963 - remove NGSI-v1 path of execution
4. Fix documentation (moving examples to NGSI-v2, remove NGSI-v1 specific topics, etc.)
5. Do a final check (grep-wise) for “NGSIv1”, “NGSI-v1”, “NGSI v1”, "v1", etc. to remove any additional leftover that could remain after the accomplished above steps

Questions

• Anything missing with this course of action?
• This would of course be a breaking change - would the package move to 3.0.0?
• Should this update be aligned with full NGSI-LD support being completed?

[jason-fox]

Following on from: telefonicaid/iotagent-ul#460 (comment) and isCurrentNGSI() changes

Removing stuff from the Lib will be easy, but there will need to be testing on the various downstream projects. Should there be a release of the IoT Agents before attempting the removal?

[fgalan]

We think removing deprecated NGSI-v1 from IOTAs would be a good idea. Please find feedback below.

Anything missing with this course of action?

We would suggest to add two extra items to the list of checkboxes:

• Fix documentation (moving examples to NGSI-v2, remove NGSI-v1 specific topics, etc.)
• Do a final check (grep-wise) for “NGSIv1”, “NGSI-v1”, “NGSI v1”, "v1", etc. to remove any additional leftover that could remain after the accomplished above steps

This would of course be a breaking change - would the package move to 3.0.0?

Makes sense. In IOTAs probably we should to the same and move to 2.0.0.

Should this update be aligned with full NGSI-LD support being completed?

We think they are independent things. I mean, NGSI-v1 removal can be started without waiting for NGSI-LD support being completed.

Should there be a release of the IoT Agents before attempting the removal?

We think it would be a good idea. Although the PRs can be started now, they will be merged after a new release had been done. However, I think that new release will be done soon.

[jason-fox]

Although the PRs can be started now, they will be merged after a new release had been done. However, I think that new release will be done soon.

Related to #970 - a potential timetable for this is as follows:

1. In the current release 2.14.0 NGSI-v1 is deprecated but still supported.
2. In the next release 2.15.0 NGSI-v1 is deprecated but still supported. (released before May 2021)
3. NGSI-v1 can then be removed - without class refactoring

[fgalan]

I'd say that after merging PR #995 and all the related others in IOTAs repos this issue is complete. There are some checkboxes above not marked, but probably they are completed tasks.

@jason-fox could you have a look and close this issue if you think everything is completed, please?

[jason-fox]

This task is completed.