From 0c39ff3efd7704c91c10af232ceeded85cc434fb Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Thu, 21 Sep 2023 11:40:36 +0200 Subject: [PATCH 1/4] set useUnifiedTopology = true to remove warn --- lib/model/dbConn.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/model/dbConn.js b/lib/model/dbConn.js index 1ea6d8d71..d642f4ff2 100644 --- a/lib/model/dbConn.js +++ b/lib/model/dbConn.js @@ -112,6 +112,7 @@ function init(host, db, port, options, callback) { // but not sure if current mongoose version is still using mongodb 3.x internally // probably mongodb-connectionoptions-test.js needs to be fixed if useNewUrlParser is removed at the end options.useNewUrlParser = true; + options.useUnifiedTopology = true; mongoose.set('useCreateIndex', true); /* eslint-disable-next-line no-unused-vars */ const candidateDb = mongoose.createConnection(url, options, function (error, result) { From 6ec753d199fa3d53c30fb67a1cb6f9a346417b8d Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Thu, 21 Sep 2023 12:06:02 +0200 Subject: [PATCH 2/4] update mongo options in tests --- .../mongodb/mongodb-connectionoptions-test.js | 48 ++++++++++++------- 1 file changed, 32 insertions(+), 16 deletions(-) diff --git a/test/unit/mongodb/mongodb-connectionoptions-test.js b/test/unit/mongodb/mongodb-connectionoptions-test.js index 31bafafce..84953989e 100644 --- a/test/unit/mongodb/mongodb-connectionoptions-test.js +++ b/test/unit/mongodb/mongodb-connectionoptions-test.js @@ -76,7 +76,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -88,7 +89,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:98765/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -100,7 +102,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/examples', options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -113,7 +116,8 @@ describe('dbConn.configureDb', function () { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { replicaSet: 'rs0', - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -125,7 +129,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -137,7 +142,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -154,7 +160,8 @@ describe('dbConn.configureDb', function () { user: 'user01', password: 'pass01' }, - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -167,7 +174,8 @@ describe('dbConn.configureDb', function () { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { authSource: 'admin', - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -190,7 +198,8 @@ describe('dbConn.configureDb', function () { password: 'pass01' }, authSource: 'admin', - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -203,7 +212,8 @@ describe('dbConn.configureDb', function () { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { ssl: true, - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -217,7 +227,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME + '?retryWrites=true', options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -235,7 +246,8 @@ describe('dbConn.configureDb', function () { dbConn.DEFAULT_DB_NAME + '?retryWrites=true&readPreference=nearest', options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -247,7 +259,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -259,7 +272,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -271,7 +285,8 @@ describe('dbConn.configureDb', function () { expected: { url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME, options: { - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } }, @@ -302,7 +317,8 @@ describe('dbConn.configureDb', function () { }, authSource: 'admin', ssl: true, - useNewUrlParser: true + useNewUrlParser: true, + useUnifiedTopology: true } } } From 034836742c131f37a1a026783b2bb5b7f0aa03d5 Mon Sep 17 00:00:00 2001 From: Alvaro Vega Date: Fri, 22 Sep 2023 12:39:17 +0200 Subject: [PATCH 3/4] Update CHANGES_NEXT_RELEASE --- CHANGES_NEXT_RELEASE | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE index e69de29bb..e88d9fae1 100644 --- a/CHANGES_NEXT_RELEASE +++ b/CHANGES_NEXT_RELEASE @@ -0,0 +1 @@ +- Fix remove mongo DeprecationWarning: current Server Discovery and Monitoring engine is deprecated by adding set useUnifiedTopology = true From fae5a06eb4a7355739a911ee6c8937e4dbf61e91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ferm=C3=ADn=20Gal=C3=A1n=20M=C3=A1rquez?= Date: Fri, 22 Sep 2023 12:49:27 +0200 Subject: [PATCH 4/4] Update CHANGES_NEXT_RELEASE --- CHANGES_NEXT_RELEASE | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE index e88d9fae1..86be12d32 100644 --- a/CHANGES_NEXT_RELEASE +++ b/CHANGES_NEXT_RELEASE @@ -1 +1,2 @@ -- Fix remove mongo DeprecationWarning: current Server Discovery and Monitoring engine is deprecated by adding set useUnifiedTopology = true +- Fix: remove mongo `DeprecationWarning: current Server Discovery and Monitoring engine is deprecated` by setting `useUnifiedTopology = true` +