Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting TypeError: undefined is not an object (evaluating 'combination.replace') error in console on every page #298

Open
nikitavoloboev opened this issue Apr 16, 2024 · 3 comments
Labels

Comments

@nikitavoloboev
Copy link

image

TypeError: undefined is not an object (evaluating 'combination.replace')

With this Vimari config:

  "excludedUrls": "",
  "linkHintCharacters": "asdfjklqwerzxc",
  "detectByCursorStyle": false,
  "scrollSize": 150,
  "openTabUrl": "",
  "modifier": "",
  "smoothScroll": true,
  "scrollDuration": 25,
  "transparentBindings": true,
  "bindings": {
      "hintToggle": "f",
      "newTabHintToggle": "shift+f",
      "scrollUp": "k",
      "scrollDown": "j",
      "scrollLeft": "h",
      "scrollRight": "l",
      "scrollUpHalfPage": "u",
      "scrollDownHalfPage": "d",
      "goToPageTop": "g g",
      "goToPageBottom": "shift+g",
      "goToFirstInput": "g i",
      "goBack": "shift+h",
      "goForward": "shift+l",
      "tabForward": "w",
      "tabBack": "q",
      "closeTab": "x"
  }

Happens all the time on all web pages, not sure why.

@nikitavoloboev
Copy link
Author

image

found this in code, any idea of what can be causing this?

@nikitavoloboev
Copy link
Author

image

trying this fix

@nikitavoloboev
Copy link
Author

Getting this build error trying to run Vimari in Xcode (latest commit to main branch)

image

Sorry for ping @danielcompton and @simeg but I would love to resolve this, I want to make improvements to Vimari in general, starting with this bug, will handle other issues later, just need to be able to run the extension locally ♥️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant