Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make sure all client responses are user-instantiable/mockable #228

Open
cretz opened this issue Apr 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Apr 22, 2024

Describe the solution you'd like

Today some things, such as workflow list result, are only instantiable via internal constructor which makes it difficult for users to test. Try to make everything that could come back from a client able to be instantiated by a user. What many clients do (e.g. just checked Azure clients) is make their classes simple classes with parameterless constructors and have all properties also have setters. This may be preferred over our current stance of getter-only properties that cannot be customized in test situations.

@cretz cretz added the enhancement New feature or request label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant