Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make Temporalio.Testing to a seperate nuget out of Temporalio #229

Open
rsr-maersk opened this issue Apr 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rsr-maersk
Copy link

Is your feature request related to a problem? Please describe.

Temporalio.Testing is currently a part of the Temporalio package. I think it is better to decouple so we don't distribute test code to production
image

Describe the solution you'd like

  • make Temporalio.Testing into a separate nuget
  • make Temporalio not reference Temporalio.Testing
@rsr-maersk rsr-maersk added the enhancement New feature or request label Apr 22, 2024
@cretz
Copy link
Member

cretz commented Apr 22, 2024

This is more "test helpers" but they are harmless if not used (i.e. don't bring in extra dependencies). Technically this code is totally valid in production if people want to use it there. If you're concerned about certain code using certain packages, you may be able to use a configurable linter. We primarily only keep things in separate versioned packages if they cause dependency issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants