Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET Trimming #286

Open
angusbjones opened this issue Jun 25, 2024 · 1 comment
Open

Support .NET Trimming #286

angusbjones opened this issue Jun 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@angusbjones
Copy link

What are you really trying to do?

Publish trimmed/aot-compatible dotnet applications.

Describe the bug

Temporalio (and other packages) don't have trimming annotations included which produces errors when publishing with trimming enabled.

Minimal Reproduction

  1. Download the sample at src/AspNet/Worker.
  2. Modify TemporalioSamples.AspNet.Worker.csproj to include <PublishTrimmed>true</PublishTrimmed>
  3. Run dotnet publish on TemporalioSamples.AspNet.Worker.csproj.

Environment/Versions

  • OS and processor: M1 Mac
  • Temporal Version: 1.1.2
  • Are you using Docker or Kubernetes or building Temporal from source? Package
@angusbjones angusbjones added the bug Something isn't working label Jun 25, 2024
@cretz
Copy link
Member

cretz commented Jun 25, 2024

I think this is not a bug, but rather a feature request to have the SDK support trimming. There are some things we'll have to do since we use PInvoke and reflection in some places. We will keep this open as a feature request for trimming support and if it garners enough interest, we can look into annotating the SDK for it and running all tests while trimmed to ensure it works and continues to.

@cretz cretz changed the title [Bug] PublishTrimmed cannot be used due to Temporalio trim warnings Support .NET Trimming Jun 25, 2024
@cretz cretz added enhancement New feature or request and removed bug Something isn't working labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants