Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Rust cache using newer node version #177

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Jan 16, 2024

What was changed

We use older container for glibc compat when building binaries, but rust-cache doesn't work in that container by default anymore. So we fixate the rust-cache version. See Swatinem/rust-cache#183 (comment).

Tested in this issue by forcing this workflow to run in this PR under draft then removed that force.

@cretz cretz requested a review from a team January 16, 2024 15:37
@cretz cretz marked this pull request as ready for review January 16, 2024 15:38
@cretz cretz merged commit ba4763b into temporalio:main Jan 20, 2024
7 checks passed
@cretz cretz deleted the rust-cache-fix branch January 20, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants