Accept search attributes for dev server #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now ready for review |
mjameswh
approved these changes
Jan 24, 2025
|
Don't you have any preexisting tests in the repo that were using custom search attributes, and should be updated to use this? |
Yes, though not sure they need to be updated since they work today, but they can be. This may not always be the case for other SDKs because if their tests are interchangeable with the time-skipping server, that only works with the operator service approach still. |
|
The way the test harness code is setup, it separates the server setup from the search attribute creation. I think it's worth keeping that separation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Temporalio.Testing.WorkflowEnvironmentStartLocalOptionsnow acceptsSearchAttributesoptionThere is an issue with the dev server using search attributes, currently blocked on temporalio/temporal#6195. Leaving as draft for now.EDIT: Now ready for reviewChecklist