Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jQuery's version condition #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix jQuery's version condition #222

wants to merge 1 commit into from

Conversation

Steve-VE
Copy link

@Steve-VE Steve-VE commented Dec 6, 2018

Must use double == since you compare string and number (so, '1' === 1 will be false).
Also, I think the error message or the condition ins't correct because it accepts some version before 3.0.0 (I use it with jQuery 1.11.1 and it pass the condition).

Must use double == since you compare string and number (so, '1' === 1 will be false).
Also, I think the error message or the condition ins't correct because it accepts some version before 3.0.0 (I use it with jQuery 1.11.1 and it pass the condition).
@tonix-tuft
Copy link

This project seems to be unmaintained as the maintainer is unresponsive.
I have sent several pull requests, but they all have been ignored.

I have some plans about developing it further, so I have forked both
tempusdominus/core and tempusdominus/bootstrap-4:

They are also available through NPM:

In these two forks (I worked on the fork branch on both, not on master) I have updated all the NPM dependencies and build scripts,
added some new features and fixed some bugs I have discovered while using Tempus Dominus.

For now, I have left the master branch in my forks intact and the same as in the original repos, as I was waiting for my PR being merged
in the original repos and I am adding patches/bugfixes and new features on the fork branch in both forked projects.

If you have some pending PR you would like to merge, I invite you to fork my forks instead and we can work
on it together in the free time.

@HaroldPutman already sent me a PR which got merged in tonix-tuft/tempusdominus -> tonix-tuft/tempusdominus#1.

P.S.: I have also created a React version of Tempus Dominus Bootstrap, available here (I hope you enjoy it 😃):

@tonix-tuft
Copy link

Hello guys,

I have sent all the PRs we have already merged into my two forks (https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap)
to the main repo of Eonasdan directly on master.

I wanna thank @HaroldPutman, @pablo-lp and @zondatw for their contribution.

I think that now it makes sense for us to continue to work on this project in my two forks and from the master branch instead of the fork branch I have created and used so far
because I was waiting for @Eonasdan to merge the features we added to its main repo.

But again, as @Eonasdan was and still is unresponsive, I think it would make sense to continue the development from the two forked repos https://github.com/tonix-tuft/tempusdominus and https://github.com/tonix-tuft/tempusdominus-bootstrap now using the master branch instead of fork as the starting point from which to fork the branches for your PRs.

As always, PRs for new features, bugfixes are welcome! Thank you. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants