-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ziga/og fix frontend issues from workshop #1525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor bits.
One question, perhaps for a different PR. How does the connect to metamask process happen ? Typically there's a button for it right ?
The issue is a bit hidden to be fair. It comes from infura / an rpc response, not from Metamask. A try-catch seems to do the trick.
|
Why this change is needed
In this PR I fixed a few frontend bugs and added new features:
While doing this I fixed 2 bugs on OG backend:
eth_blockNumber
- especially problematic after revoking as we are calling it with userID which is not valid anymore, but is still in the rpcURL in Metamask)What changes were made as part of this PR
Please provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks