Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .env files for centralizing github enviroment variables #1537

Closed
wants to merge 3 commits into from

Conversation

otherview
Copy link
Contributor

@otherview otherview commented Sep 20, 2023

Why this change is needed

As per title, takes @BedrockSquirrel PR and uses a .env file to load the variables.
Now variables and values are in the code, only secrets are in GH.

@otherview otherview force-pushed the pedro/sepolia-testnet branch from 87c640b to 3437839 Compare September 20, 2023 11:11
@otherview otherview force-pushed the pedro/sepolia-testnet branch 2 times, most recently from b764a42 to 54be0fc Compare September 20, 2023 11:23
@otherview otherview force-pushed the pedro/sepolia-testnet branch 2 times, most recently from a1e125e to dbc8a55 Compare September 20, 2023 11:36
@otherview otherview force-pushed the pedro/sepolia-testnet branch from dbc8a55 to eddea3e Compare September 20, 2023 11:38
@otherview otherview changed the title testing .env Using .env files for centralizing github enviroment variables Sep 20, 2023
@BedrockSquirrel
Copy link
Collaborator

As discussed in discord, I'm not against this but not clear to me that having these checked in is any better than having them in the GH envs.

Also if you want to keep the URLs non-secret then you'll need to find a way to provide the sepolia ones differently so bit of work still required.

So I'd suggest parking this for now and revisiting soon as part of a wider config rethink (but I'm not against it going in if others think it is an improvement worth making).

@otherview
Copy link
Contributor Author

Typically I choose to have as much as possible of code and configs in the codebase instead of in managed services.
I can see pros and cons of using GH Environment Variables and Environment Secrets vs using .env files + 'env'_named secrets. But no deciding factor tbh.

General consensus is to use GH Environment Variables and Environment Secrets, we'll try that and can always change if needed 👏

@otherview otherview closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants