Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly change dockerisation approach and add better docs/directions #1

Open
benjiboi214 opened this issue Jan 21, 2021 · 1 comment

Comments

@benjiboi214
Copy link

Hi!

Thanks for everyone's hard work here so far, love having a place to start.

I've just been through a bit of an effort trying to get this repo running in my k8s environment and ran into a few gotchas that no doubt will cause others some pain in the future.

Notably:

  • Injecting secrets into the config run.sh (setup_keys/create_settings) after build is a nightmare and leads to issues down the road if you try to add caching
  • Running the tendenci start project in the install.sh script means that when using k8s you have issues where the volume I want to mount to persist the project settings overwrites the container's existing project content.
  • No support for the prod install settings (libmemcached)
  • No support for things like CONN_MAX_AGE or SSL mode on DB connections (much needed for the number of DB requests tendenci seems to make)

I have a branch in my fork that needs a bit of a clean up, but wondering if you would be interested in looking at a PR at some point in the near future? If yes, can actually do the clean up and make it worthy of a merge :D

Thanks in advance.

@jennyq
Copy link
Member

jennyq commented Jan 21, 2021

@benjiboi214,
Yes, PRs are always welcome. Thank you!

jennyq pushed a commit that referenced this issue Jul 3, 2022
…77e0e2f2f

[Snyk] Security upgrade ubuntu from 18.04 to 20.04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants