Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulation test: out of gas error when handling lot of denoms #746

Open
lumtis opened this issue Apr 25, 2022 · 2 comments
Open

Simulation test: out of gas error when handling lot of denoms #746

lumtis opened this issue Apr 25, 2022 · 2 comments
Labels
test Improve tests

Comments

@lumtis
Copy link
Contributor

lumtis commented Apr 25, 2022

out of gas error may occur during simulation tests when having a lot of denoms handled, vouchers in our case
Fees in simulation tests in SDK are paid with all denoms. Then all the denom rewards are auto-claimed which triggers the out of gas.

Potential solution on SDK:

  • make auto-claim gasless
  • change RandomFees to use a single denom

Potential solution on our chain:

  • Limit number of created vouchers

Don't hesitate to put more information @giunatale
@lumtis lumtis added the test Improve tests label Apr 25, 2022
@giunatale
Copy link
Contributor

For context, see also #369

@lumtis
Copy link
Contributor Author

lumtis commented May 4, 2022

NOTE: when we want to perform big simulation, we can still decrease the weight for the operations minting vouchers and unredeeming

	defaultWeightMsgMintVouchers      = 1
	defaultWeightMsgUnredeemVouchers  = 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lumtis @giunatale