Skip to content

Commit

Permalink
Merge pull request #127 from hartwork/ui-testing-ci-recent-enough-asc…
Browse files Browse the repository at this point in the history
…iinema

recordings: Make record.sh ensure recent enough asciinema
  • Loading branch information
hartwork authored Nov 27, 2023
2 parents 1cfafdc + 257ad5e commit 4ba5eb0
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/linux_and_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
brew tap homebrew/cask-fonts
brew install \
agg \
asciinema \
coreutils \
font-liberation \
imagemagick
Expand Down Expand Up @@ -121,6 +120,7 @@ jobs:
if: "${{ runner.os == 'macOS' }}"
run: |-
./recordings/record.sh
rm -Rf recordings/venv/
- name: 'Upload UI test renderings for inspection'
if: "${{ runner.os == 'macOS' }}"
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ On a Debian-based Linux including Ubuntu, you would need to install…
```console
$ sudo apt-get update
$ sudo apt-get install --no-install-recommends -V \
asciinema \
ca-certificates \
cargo \
fonts-liberation
fonts-liberation \
python3-venv
$ cargo install --git https://github.com/asciinema/agg
```

Expand Down
1 change: 1 addition & 0 deletions recordings/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/venv/
/actual*.*
/diff*.png
5 changes: 5 additions & 0 deletions recordings/record.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export FAKETIME=yesplease

cd "${self_dir}"

# Ensure recent asciinema with --cols and --rows argument support
[[ -d venv/ ]] || python3 -m venv venv/
source venv/bin/activate
pip3 install asciinema==2.3.0

# Check and report on runtime requirements
which agg asciinema convert realpath timeout ttyplot

Expand Down

0 comments on commit 4ba5eb0

Please sign in to comment.