Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordings: Make record.sh ensure recent enough asciinema #127

Merged

Conversation

hartwork
Copy link
Collaborator

No description provided.

@hartwork hartwork force-pushed the ui-testing-ci-recent-enough-asciinema branch from 740a16e to 257ad5e Compare November 27, 2023 15:50
@edgar-bonet
Copy link
Collaborator

I don't really get why asciinema needs --cols and --rows. It normally works fine without that. I would argue that, providing terminal dimensions is really the job of the terminal emulator. In this case, the job of headless.py. Can't this script fix the terminal dimensions?

@hartwork
Copy link
Collaborator Author

hartwork commented Nov 27, 2023

I don't really get why asciinema needs --cols and --rows. It normally works fine without that. I would argue that, providing terminal dimensions is really the job of the terminal emulator. In this case, the job of headless.py. Can't this script fix the terminal dimensions?

@edgar-bonet I did not find a way that worked personally, I did try but rather ran into issues like asciinema/agg#62 than success. If you want to play with an alternative and make it work from, inside headless.py so that it works fine on both local Linux and in macOS CI that's welcome, but making sure that everyone runs the same version of asciinema will likely not only be more economic but also fix other issues from divergence in version that we may have in the future, also. What do you think?

Copy link
Collaborator

@edgar-bonet edgar-bonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I may try later to get the terminal defined in the Python script (not much time now), as I don't like that much having software installations “local” to one project. In the mean time, this deserves merging IMO.

@hartwork
Copy link
Collaborator Author

OK. I may try later to get the terminal defined in the Python script (not much time now), as I don't like that much having software installations “local” to one project. In the mean time, this deserves merging IMO.

@edgar-bonet thanks! 👍

@hartwork hartwork merged commit 4ba5eb0 into tenox7:development Nov 27, 2023
5 checks passed
@hartwork hartwork deleted the ui-testing-ci-recent-enough-asciinema branch November 27, 2023 22:15
@hartwork hartwork added this to the 1.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants