Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recordings: Make record.sh ensure recent enough asciinema #127

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linux_and_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
brew tap homebrew/cask-fonts
brew install \
agg \
asciinema \
coreutils \
font-liberation \
imagemagick
Expand Down Expand Up @@ -114,6 +113,7 @@ jobs:
if: "${{ runner.os == 'macOS' }}"
run: |-
./recordings/record.sh
rm -Rf recordings/venv/

- name: 'Upload UI test renderings for inspection'
if: "${{ runner.os == 'macOS' }}"
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ On a Debian-based Linux including Ubuntu, you would need to install…
```console
$ sudo apt-get update
$ sudo apt-get install --no-install-recommends -V \
asciinema \
ca-certificates \
cargo \
fonts-liberation
fonts-liberation \
python3-venv
$ cargo install --git https://github.com/asciinema/agg
```

Expand Down
1 change: 1 addition & 0 deletions recordings/.gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/venv/
/actual*.*
/diff*.png
5 changes: 5 additions & 0 deletions recordings/record.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export FAKETIME=yesplease

cd "${self_dir}"

# Ensure recent asciinema with --cols and --rows argument support
[[ -d venv/ ]] || python3 -m venv venv/
source venv/bin/activate
pip3 install asciinema==2.3.0

# Check and report on runtime requirements
which agg asciinema convert realpath timeout ttyplot

Expand Down