Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for batching parameter pad_variable_length_inputs #1934

Open
jeongukjae opened this issue Nov 3, 2021 · 5 comments
Open

Docs for batching parameter pad_variable_length_inputs #1934

jeongukjae opened this issue Nov 3, 2021 · 5 comments

Comments

@jeongukjae
Copy link

When I use TF-Serving with batching options and variable length inputs, I could get errors like Tensors with name 'example_feature:0' from different tasks have different shapes and padding is turned off.Set pad_variable_length_inputs to true, or ensure that all tensors with the same namehave equal dimensions starting with the first dim., and I could find codes related to that parameters.

But in batching guide(https://github.com/tensorflow/serving/blob/master/tensorflow_serving/batching/README.md), there is no description about parameter pad_variable_length_inputs.

Can you add descriptions for pad_variable_length_inputs in the batching guide?

@denadai2
Copy link

+1

1 similar comment
@YoungXu06
Copy link

+1

@singhniraj08 singhniraj08 self-assigned this Feb 3, 2023
@singhniraj08
Copy link

@jeongukjae,

Descriptions on pad_variable_length_inputs batching parameter can be found in tensorflow_serving/batching/batching_options.h file.

Thank you!

@jeongukjae
Copy link
Author

@singhniraj08 Thank you for your help :) I was able to find the related code and understand it, but I think it would be even more helpful if this argument was added to the "TensorFlow Serving Batching Guide" documentation.

@singhniraj08 singhniraj08 assigned christisg and unassigned godot73 Feb 7, 2023
@singhniraj08
Copy link

@christisg,

Can we add pad_variable_length_inputs parameter description in TensorFlow Serving Batching Guide.
I can create a PR to update the doc.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants