-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tensorflow Stub DType #6899
Comments
…l stubs Fixes: #17 The stubs could be simplified after resolving: tensorflow/tensorboard#6899
Hmmm... I don't know if we want to include this dependency at this point. Honestly, I'm not well aware at this time of how this impacts users. Those types seem to be noted as "experimental" in some way. Have you experienced any issues with the tool because of this? |
Hi @arcra, I haven't encountered any issues with tensorboard, but I noticed that the stubs have significantly diverged from the main TensorFlow repository. Do you think we should update them now, or would it be better to resolve this when something breaks in the future? |
Yes, honestly, we don't have bandwidth at the moment, and it's unclear if users are using these, and to what extent other parts of the code need to be updated. It looks like our So I'd punt it until someone asks for support for this, but we can keep this open for now. Thanks for letting us know. |
Environment information (required)
Not related.
Issue description
The tensorflow stub
tensorboard/compat/tensorflow_stub/dtypes.py
does not include certain types in the latest tensorflowtensorflow/python/framework/dtypes.py
. Such as:types_pb2.DT_FLOAT8_E5M2_REF
types_pb2.DT_FLOAT8_E4M3FN_REF
types_pb2.DT_INT4_REF
types_pb2.DT_UINT4_REF
These types exist in
tensorboard/compat/proto/types.proto
and intensorflow/python/framework/dtypes.py
.I can open a PR to update the
dtypes.py
file according to the latest tensorflow code. However, I think it will require addingml_dtypes
as an extra dependency, and I'm not sure if this is the preferred approach.The text was updated successfully, but these errors were encountered: