-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ruff rule B027 and B024 #6950
Merged
lego0901
merged 8 commits into
tensorflow:master
from
janasangeetha:sangeethajana-patch1
Nov 15, 2024
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2fe6c5f
Fix Ruff rule B027
janasangeetha 83abbc0
Fix Ruff rule B027
janasangeetha e438a8b
Fix Ruff rule B024
janasangeetha e01bc0f
Fix Ruff rules
janasangeetha 6759017
Added new line at EOF
janasangeetha dfb5516
Added new line at EOF
janasangeetha 5ec4d6c
Fix lint errors
janasangeetha c034df5
Fix ruff rules
janasangeetha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
"""Base class to patch DagRunner classes in TFX CLI.""" | ||
|
||
#ruff: noqa: B027 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you prefer global noqa over specific lines? I personally lean toward using |
||
import abc | ||
import contextlib | ||
import functools | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also a nit comment; as a coding convention, we were using two spaces before any comment
#
. This was warned when we are on the internal Google land, but I am not sure if it is captured by the linter here.@smokestacklightnin could you let me know if this comment style is acceptable by the linter?
pylint --rcfile ./pylintrc tfx/types/system_executions.py
didn't warn meThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe the number of spaces matters. I tried with zero, one, and two spaces, and all three options passed
ruff check
.