Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ruff rule B027 and B024 #6950

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Fix Ruff rule B027 and B024 #6950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2fe6c5f
Fix Ruff rule B027
janasangeetha Nov 4, 2024
83abbc0
Fix Ruff rule B027
janasangeetha Nov 4, 2024
e438a8b
Fix Ruff rule B024
janasangeetha Nov 4, 2024
e01bc0f
Fix Ruff rules
janasangeetha Nov 5, 2024
6759017
Added new line at EOF
janasangeetha Nov 5, 2024
dfb5516
Added new line at EOF
janasangeetha Nov 5, 2024
5ec4d6c
Fix lint errors
janasangeetha Nov 5, 2024
c034df5
Fix ruff rules
janasangeetha Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfx/orchestration/portable/base_executor_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ def with_execution_watcher(
self._execution_watcher_address = execution_watcher_address
return self

def handle_stop(self) -> None:
def handle_stop(self) -> None: # noqa: B027
"""Executor Operator specific logic to clean up after it is stopped."""
pass
6 changes: 3 additions & 3 deletions tfx/tools/cli/handler/dag_runner_patcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
"""Base class to patch DagRunner classes in TFX CLI."""

#ruff: noqa: B027
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you prefer global noqa over specific lines? I personally lean toward using # noqa: B027 only for specific lines because new contributors could ignore all B027 rules on the same file, which isn't desirable for the code health.

import abc
import contextlib
import functools
Expand Down Expand Up @@ -56,12 +56,12 @@ def __init__(self, call_real_run=True):
self._run_called = False
self._call_real_run = call_real_run

def _before_run(self, runner: tfx_runner.TfxRunner,
def _before_run(self, runner: tfx_runner.TfxRunner, # noqa: B027
pipeline: Union[pipeline_pb2.Pipeline, tfx_pipeline.Pipeline],
context: MutableMapping[str, Any]) -> None:
pass

def _after_run(self, runner: tfx_runner.TfxRunner,
def _after_run(self, runner: tfx_runner.TfxRunner, # noqa: B027
pipeline: Union[pipeline_pb2.Pipeline, tfx_pipeline.Pipeline],
context: MutableMapping[str, Any]) -> None:
pass
Expand Down
3 changes: 1 addition & 2 deletions tfx/types/system_artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from ml_metadata.metadata_store import mlmd_types


class SystemArtifact(abc.ABC):
class SystemArtifact(abc.ABC): # noqa: B024
"""TFX system artifact base class.
A user may create a subclass of SystemArtifact and override the
Expand All @@ -30,7 +30,6 @@ class SystemArtifact(abc.ABC):
The subclasses, e.g, Dataset, Model, Statistics, e.t.c, match the MLMD types
from third_party/ml_metadata/metadata_store/mlmd_types.py.
"""

# MLMD system base type enum. Override it when creating subclasses.
MLMD_SYSTEM_BASE_TYPE = None

Expand Down
3 changes: 1 addition & 2 deletions tfx/types/system_executions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from ml_metadata.metadata_store import mlmd_types


class SystemExecution(abc.ABC):
class SystemExecution(abc.ABC): # noqa: B024
"""TFX system execution base class.
A user may create a subclass of SystemExecution and override the
Expand All @@ -30,7 +30,6 @@ class SystemExecution(abc.ABC):
The subclasses, e.g, Train, Transform, Process, e.t.c, match the MLMD types
from third_party/ml_metadata/metadata_store/mlmd_types.py.
"""

# MLMD system base type enum. Override it when creating subclasses.
MLMD_SYSTEM_BASE_TYPE = None

Expand Down
Loading