Enabling eth cores on BH and initializing FW on active eriscs #18130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
3 times, most recently
from
5d35a12 to
3064977
Compare
abhullar-tt
changed the title
abhullar-tt
commented
Feb 22, 2025
abhullar-tt
requested review from
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
davorchap,
cfjchu and
omilyutin-tt
as code owners
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
from
3064977 to
8adc432
Compare
aliuTT
approved these changes
Feb 26, 2025
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
2 times, most recently
from
7152db8 to
50c4f05
Compare
abhullar-tt
commented
Feb 26, 2025
| @@ -80,7 +80,7 @@ dram_view_size: | |||
|
|
|||
| eth: | |||
| [ | |||
| #1-1, 2-1, 3-1, 4-1, 5-1, 6-1, 7-1, 10-1, 11-1, 12-1, 13-1, 14-1, 15-1, 16-1, | |||
| 1-1, 16-1, 2-1, 15-1, 3-1, 14-1, 4-1, 13-1, 5-1, 12-1, 6-1, 11-1, 7-1, 10-1, | |||
There was a problem hiding this comment.
updated to match UMD descriptors and follow eth ID spec in: https://docs.google.com/spreadsheets/d/1tGG4UPfABXrd97Y3VPJS7CusDFlamcml9kEw1HEwrlM/edit?gid=95904394#gid=95904394
| @@ -20,6 +20,36 @@ class MultiDeviceFixture : public DispatchFixture { | |||
| void SetUp() override { this->arch_ = tt::get_arch_from_string(tt::test_utils::get_umd_arch_name()); } | |||
| }; | |||
|
|
|||
| class TwoDeviceFixture : public MultiDeviceFixture { | |||
There was a problem hiding this comment.
Is the only difference between this and the N300 fixture below in that we dropping tt::ARCH::WORMHOLE_B0 assertion? Do we intend to run this test on both BH and WH?
There was a problem hiding this comment.
yeah this should be on both BH and WH, there are some other N300 specific tests which is why I didn't remove the N300 fixture
| @@ -159,6 +159,7 @@ class Hal { | |||
| bool coordinate_virtualization_enabled_; | |||
| uint32_t virtual_worker_start_x_; | |||
| uint32_t virtual_worker_start_y_; | |||
| bool eth_fw_is_cooperative_; // set when eth riscs have to context switch | |||
There was a problem hiding this comment.
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
from
50c4f05 to
77bea04
Compare
| @@ -302,7 +305,7 @@ class Cluster { | |||
| // Need to hold reference to cluster descriptor to detect total number of devices available in cluster | |||
| // UMD static APIs `detect_available_device_ids` and `detect_number_of_chips` only returns number of MMIO mapped | |||
| // devices | |||
| std::unique_ptr<tt_ClusterDescriptor> cluster_desc_; | |||
| tt_ClusterDescriptor* cluster_desc_; | |||
There was a problem hiding this comment.
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
3 times, most recently
from
7409fd8 to
bc07969
Compare
abhullar-tt
force-pushed
the
abhullar/bh-p150
branch
from
bc07969 to
c027c61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#18038
What's changed
Last set of changes that enable loading FW onto active erisc cores.
This PR points to a UMD branch with some fixes for detecting BH multi-chip connectivity. UMD branch will be mainlined before this PR is merged.
Includes
Eth links on BH are pretty flaky (https://tenstorrent.atlassian.net/browse/BH-84)
Note: Fabric support needs some additional fixes that are on a separate branch (abhullar/bh-multichip)
Checklist