Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18064: Workaround for multiple matmul hangs: #18359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncvetkovicTT
Copy link
Contributor

@ncvetkovicTT ncvetkovicTT commented Feb 26, 2025

Ticket

#18064 #18065 #17099 #16673

Problem description

Disabling instruction cache doesn't happen in time for subsequent TTI instruction not to end up in the cache. In order to properly disable I$, we need to disable branch prediction first. Since reprogramming the REPLAY buffers needs to happen when the cache is disabled, SFPI compiler cannot rely on REPLAY buffers. These things introduce multiple matmul hangs.

What's changed

  • Guard CSRRS by disabling branch prediction
  • Add a compiler flag which makes the SFPI compiler not to use replay buffers

Checklist

- Guard CSRRS by disabling branch prediction
- Add a compiler flag which makes the SFPI compiler
not to use replay buffers
@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/18064_mmul_parent_case branch from 8f4e20e to cf920b5 Compare February 26, 2025 17:47
@ncvetkovicTT
Copy link
Contributor Author

@nathan-TT Is the place where I need to add the compiler flag correct?

@nathan-TT
Copy link
Contributor

@nathan-TT Is the place where I need to add the compiler flag correct?

looks right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants