From 9d3726dda3e67816715000938f29c9417beebc4a Mon Sep 17 00:00:00 2001 From: peterdemartini Date: Fri, 20 Aug 2021 13:32:34 -0700 Subject: [PATCH 1/3] Bump --- asset/asset.json | 2 +- asset/package.json | 2 +- package.json | 4 ++-- packages/file-asset-apis/package.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/asset/asset.json b/asset/asset.json index a730368a..6d8485b1 100644 --- a/asset/asset.json +++ b/asset/asset.json @@ -1,5 +1,5 @@ { "name": "file", - "version": "2.1.7", + "version": "2.1.8", "description": "A set of processors for working with files" } diff --git a/asset/package.json b/asset/package.json index 3b4722fa..3ec3d074 100644 --- a/asset/package.json +++ b/asset/package.json @@ -1,6 +1,6 @@ { "name": "file", - "version": "2.1.7", + "version": "2.1.8", "description": "A set of processors for working with files", "private": true, "workspaces": { diff --git a/package.json b/package.json index 10343ac4..c915d87c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "file-assets-bundle", - "version": "2.1.7", + "version": "2.1.8", "description": "A set of processors for working with files", "repository": "https://github.com/terascope/file-assets.git", "author": "Terascope, LLC ", @@ -27,7 +27,7 @@ "dependencies": {}, "devDependencies": { "@terascope/eslint-config": "^0.6.0", - "@terascope/file-asset-apis": "^0.5.0", + "@terascope/file-asset-apis": "^0.5.1", "@terascope/job-components": "^0.53.0", "@types/fs-extra": "^9.0.12", "@types/jest": "^27.0.1", diff --git a/packages/file-asset-apis/package.json b/packages/file-asset-apis/package.json index 5a807196..10b9651e 100644 --- a/packages/file-asset-apis/package.json +++ b/packages/file-asset-apis/package.json @@ -1,6 +1,6 @@ { "name": "@terascope/file-asset-apis", - "version": "0.5.0", + "version": "0.5.1", "description": "file reader and sender apis", "publishConfig": { "access": "public" From d0f9a8b44cd9c0c23237eb73f1a483b48f9b53ec Mon Sep 17 00:00:00 2001 From: peterdemartini Date: Fri, 20 Aug 2021 13:33:00 -0700 Subject: [PATCH 2/3] Fix issue with isEmpty thinking generators are nil --- packages/file-asset-apis/src/base/ChunkGenerator.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/file-asset-apis/src/base/ChunkGenerator.ts b/packages/file-asset-apis/src/base/ChunkGenerator.ts index da3a64f3..4ec056b8 100644 --- a/packages/file-asset-apis/src/base/ChunkGenerator.ts +++ b/packages/file-asset-apis/src/base/ChunkGenerator.ts @@ -1,4 +1,4 @@ -import { isEmpty, isTest } from '@terascope/utils'; +import { isTest } from '@terascope/utils'; import { Compressor } from './Compressor'; import { Formatter } from './Formatter'; import { Format, Compression, SendRecords } from '../interfaces'; @@ -58,7 +58,7 @@ export class ChunkGenerator { } [Symbol.asyncIterator](): AsyncIterableIterator { - if (isEmpty(this.slice)) { + if (Array.isArray(this.slice) && this.slice.length === 0) { return this._emptyIterator(); } if (this.isRowOptimized()) { From 772fa94d94bed37349ab2636f262e51f797358d7 Mon Sep 17 00:00:00 2001 From: peterdemartini Date: Fri, 20 Aug 2021 13:34:53 -0700 Subject: [PATCH 3/3] Fix missing package version update --- asset/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asset/package.json b/asset/package.json index 3ec3d074..d790c939 100644 --- a/asset/package.json +++ b/asset/package.json @@ -14,7 +14,7 @@ "build:watch": "yarn build --watch" }, "dependencies": { - "@terascope/file-asset-apis": "^0.5.0", + "@terascope/file-asset-apis": "^0.5.1", "@terascope/job-components": "^0.53.0", "csvtojson": "^2.0.10", "fs-extra": "^10.0.0",