Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 is mutating the config #1125

Open
lesleydreyer opened this issue Dec 4, 2024 · 0 comments
Open

s3 is mutating the config #1125

lesleydreyer opened this issue Dec 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@lesleydreyer
Copy link
Contributor

I noticed s3 started mutating the config by adding this $source object which even though it says "e" it doesn't look like it's an error. https://github.com/aws/aws-sdk-js-v3/pull/6546/files#diff-a3590b50e293ad26b5fac14d669025732f47d6c0da0f83527e317ab3848919caR364

"credentials": {
    "accessKeyId": "minioadmin",
    "secretAccessKey": "minioadmin",
    "$source": {
        "CREDENTIALS_CODE": "e"
    }
}

I think in createS3Client if we just change it from
return new BaseClient(finalConfig);
to
return new BaseClient(cloneDeep(finalConfig));
so it doesn't mutate the config passed to createS3Client, and ensure no other s3 functions are mutating things it should be good.

@lesleydreyer lesleydreyer added the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant