Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset pulls get rate-limited in tests #3980

Open
busma13 opened this issue Feb 28, 2025 · 3 comments
Open

asset pulls get rate-limited in tests #3980

busma13 opened this issue Feb 28, 2025 · 3 comments
Assignees

Comments

@busma13
Copy link
Contributor

busma13 commented Feb 28, 2025

If too many jobs in our test suite use @terascope/fetch-github-release to download assets at the same time our github account gets rate-limited, causing the test job to fail.

We could do a couple of things:

  • cache the assets in github in an automated workflow(daily?) and pull from the cache in each job
  • run one job at the start of each workflow run that pulls assets and passes them into all the jobs that need them
@godber
Copy link
Member

godber commented Feb 28, 2025

Does fetch-github-release have a local caching mechanism?

@busma13
Copy link
Contributor Author

busma13 commented Feb 28, 2025

Does fetch-github-release have a local caching mechanism?

No it doesn't. I don't believe this would help in CI since all jobs run in separate runners, so they all have their own instance of fetch-github-release

@busma13
Copy link
Contributor Author

busma13 commented Feb 28, 2025

Or do you mean that fetch-github-release will check a specified cache before making a request to github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants