Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery-free animation engine version #1

Open
artemverbo opened this issue Mar 31, 2015 · 5 comments
Open

jQuery-free animation engine version #1

artemverbo opened this issue Mar 31, 2015 · 5 comments

Comments

@artemverbo
Copy link
Contributor

Hello!

Thank you for the project, looks really good and useful. In particular animation for OverlappingMarkerSpiderfier is amazing. Would be cool to have a jQuery-free version, as you stated in your plans for the future, just +1-ing that one :)

@viskin
Copy link
Member

viskin commented Apr 1, 2015

Thank you, pleased to hear.
Do you mean removing dependency on jQuery animation plugin, or removing dependency on jQuery for any purposes.
Technically, now I use jQuery, in addition to animation, only for $.extend method. I could implement that manually. And make user provide his own animation engine based on whatever he wants, like velocity js.
Just curious, why removing jQuery dependency would be advantageous to you?

@viskin
Copy link
Member

viskin commented Apr 4, 2015

In v0.2.0 added animateFunctionAdapter, that can be used to provide alternative animation routine.

@artemverbo
Copy link
Contributor Author

@viskin thank you! The reason is simple, for the current project I'm working on, a massive AngularJS-based app with quite a few dependencies already, so the decision was made from the beginning of it to follow the trend of being lightweight as possible and not using jQuery (as Angular has kind of a jQLite DOM-querying tiny component). So for the purpose of demoing the possible other map "clustering" solution, I've used a modified version of your lib (stripped $.extend and replaced animation engine to just static) and spiderfy, looks really nice, but can't really easily maintain that "forked" version. That whole map feature is kind of experimental at the moment in our project, but would be awesome to have your lib as a proper dependency later on when it's going to prod.

@viskin
Copy link
Member

viskin commented Apr 14, 2015

Ok, I'll remove the dependency later this week

@viskin
Copy link
Member

viskin commented Apr 17, 2015

v0.2.1 performs feature detection and uses alternative algorithm for $.extend if jQuery was not supplied.
marker-animate still has the jQuery dependency. You can provide alternative animation routine with animateFunctionAdapter that does not depend on jQuery.

PR with such one in separate file will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants