Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/test_connectionConfig.py:Adds test to for connectionConfig #128

Merged
merged 7 commits into from
Jul 26, 2020
Merged

test/test_connectionConfig.py:Adds test to for connectionConfig #128

merged 7 commits into from
Jul 26, 2020

Conversation

Pradhvan
Copy link
Contributor

@Pradhvan Pradhvan commented Jul 25, 2020 •
edited
Loading

  • Added test for test_connectionConfig.py and bumped coverage upto 75%

Closes #123

Pradhvan added 7 commits July 25, 2020 20:27
@Pradhvan
test/test_connectionConfig.py:Adds test to for connectionConfig
bd8352e 
* Added test for set_remote_auth() method
@Pradhvan
test_connectionConfig.py: Adds test for update and clear_cursor
a5a3792
@Pradhvan
Merge branch 'master' of https://github.com/terminusdb/terminusdb-cli…
b67bde2 
…ent-python into IncreaseTestCoverage#123
@Pradhvan
test_connectionConfig: Updated coverage to 75%
49e0ff5 
* Added `id_value` to store dummy string values
* Added test for user
* Added test for set_basic_auth
* Added test for db_url_fragement
* Added test for repo_base
@Pradhvan
Added connectionConfig tests for setters
5a6b809 
* Added test for test_account()
* Added test for db()
* Added test for repo()
* Added test for branch()
* Added test for ref()
@Pradhvan
Merge branch 'master' of https://github.com/terminusdb/terminusdb-cli…
aa0c2f5 
…ent-python into IncreaseTestCoverage#123
@Pradhvan
Fixes flake8 errors
6d86a4b 
* Used secrets instead of random to generate random values.
@Pradhvan
Copy link
Contributor Author

Pradhvan commented Jul 26, 2020 •
edited
Loading

@Cheukting will it be possible to merge the PR, the coverage bumped from 62% -> 75%.

Since issue #123 would eventually need a handful of PR for other modules too. So leaving it 75% isn't that bad I guess that way I can pick up other modules other than connectionConfig.py and bring them up to 75 - 80%

Name                                                     Stmts   Miss  Cover
----------------------------------------------------------------------------
terminusdb_client/__init__.py                                4      0   100%
terminusdb_client/__version__.py                             9      0   100%
terminusdb_client/woql_utils.py                             66     43    35%
terminusdb_client/woqlclient/__init__.py                     1      0   100%
terminusdb_client/woqlclient/api_endpoint_const.py          16      0   100%
terminusdb_client/woqlclient/connectionCapabilities.py     250    149    40%
terminusdb_client/woqlclient/connectionConfig.py           186     46    75%
terminusdb_client/woqlclient/dispatchRequest.py             53     11    79%
terminusdb_client/woqlclient/documentTemplate.py            27     27     0%
terminusdb_client/woqlclient/errorMessage.py                36     36     0%
terminusdb_client/woqlclient/errors.py                      21     10    52%
terminusdb_client/woqlclient/id_parser.py                   37     11    70%
terminusdb_client/woqlclient/woqlClient.py                 187     90    52%
terminusdb_client/woqldataframe/__init__.py                  1      0   100%
terminusdb_client/woqldataframe/woqlDataframe.py            61      3    95%
terminusdb_client/woqlquery/__init__.py                      2      0   100%
terminusdb_client/woqlquery/woql_core.py                    96     63    34%
terminusdb_client/woqlquery/woql_library.py                279    239    14%
terminusdb_client/woqlquery/woql_query.py                 1409    560    60%
----------------------------------------------------------------------------
TOTAL                                                     2741   1288    53%
Coverage XML written to file coverage.xml```

@Pradhvan Pradhvan changed the title [WIP]test/test_connectionConfig.py:Adds test to for connectionConfig test/test_connectionConfig.py:Adds test to for connectionConfig Jul 26, 2020
Cheukting
Cheukting approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@Cheukting Cheukting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wonderful work!!! Thank you so much

@Cheukting Cheukting merged commit c82db84 into terminusdb:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheukting Cheukting Cheukting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase test coverage
2 participants
@Pradhvan @Cheukting