Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding inheritance of environment variables to tasks and builds #4

Merged
merged 1 commit into from
Apr 4, 2022
Merged

feat: adding inheritance of environment variables to tasks and builds #4

merged 1 commit into from
Apr 4, 2022

Conversation

terran6
Copy link
Contributor

@terran6 terran6 commented Mar 31, 2022

Updated task runner and build commands to inherit environment variables.

This resolves the following issue : iboss-ptk/terrain#28

@terran6 @octalmage
feat: adding inheritance of environment variables to tasks and builds
f34dcae 
Co-Authored-By: Jason Stallings <jason@stallin.gs>
@octalmage octalmage requested a review from rtviii March 31, 2022 18:13
rtviii
rtviii approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@rtviii rtviii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fork and execSync seem to propagate variables when i do it outside builds.. even without the explicit {env} addition actually! Wonder if the problem was somewhere else to begin with. This couldn't hurt tho!

@octalmage octalmage merged commit 377e045 into terra-money:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtviii rtviii rtviii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terran6 @rtviii @octalmage