Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an openid_connect_provider resource for the dualstack endpoint #3237

Open
mmerickel opened this issue Dec 10, 2024 · 3 comments
Open
Labels

Comments

@mmerickel
Copy link

mmerickel commented Dec 10, 2024

Is your request related to a problem? Please describe.

Using module version 20.31.1.

It is not a drop-in replacement to use the new cluster_dualstack_oidc_issuer_url compared to the previous cluster_oidc_issuer_url module output.

For the old issuer_url this module creates an aws_iam_openid_connect_provider resource in the account creating the cluster. However there is not an analogous dualstack provider created for cluster_dualstack_oidc_issuer_url.

Describe the solution you'd like.

  1. Create an aws_iam_openid_connect_provider attached to the dualstack url.
  2. Export that provider from the module via cluster_dualstack_oidc_provider_arn.
  3. Provide a way / migration path to turn off the old issuer url and only create/use the dualstack version.
@mmerickel
Copy link
Author

I'm probably missing something but I guess it's worth pointing out that this dualstack issuer does not work for IRSA. If you do create a new provider with this cluster_dualstack_oidc_issuer_url and you define an IRSA role using this new provider, a pod will not properly AssumeRoleWithWebIdentity with it because the IRSA roles are still tied to the non-dualstack issuer url. The JWT injected into your pod is minted with the iss claim matching the non-dualstack issuer.

@bryantbiggs
Copy link
Member

checking on this

Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 10, 2025
@bryantbiggs bryantbiggs added wip and removed stale labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants