Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add dpd_timeout_seconds to tunnel_preshared #95

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: Add dpd_timeout_seconds to tunnel_preshared #95

merged 1 commit into from
Oct 12, 2023

Conversation

aramatev
Copy link
Contributor

Description

I think this is a simple typo, you guys are missing dpd_timeout_seconds in resource "vpn_connection" tunnel_preshared for both tunnels 1 & 2

Nothing to really test, these variables are missing and its clear they are in other types of vpn_connectino resources in your file except for tunnel_preshared.

As proof - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpn_connection

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@aramatev aramatev changed the title Bug fix: missing in tunnel_preshared var dpd_timeout_seconds fix: Fixed missing in tunnel_preshared var dpd_timeout_seconds Sep 29, 2023
@aramatev
Copy link
Contributor Author

aramatev commented Oct 3, 2023

@bryantbiggs please advise , can you accept this? it is missing from the module, and it keeps people from setting the timeout seconds in tunnels.

@aramatev
Copy link
Contributor Author

@StephenKing, @nakopoulos-profile, @bryantbiggs bump, please advise, can we merge this in? do you really need me to add to examples?
you've 4 types of vpn_connection resources and one of them is missing dpd_timeout_seconds for both tunnels

@aramatev
Copy link
Contributor Author

@antonbabenko please advise if this PR is good?

@bryantbiggs bryantbiggs changed the title fix: Fixed missing in tunnel_preshared var dpd_timeout_seconds fix: Add dpd_timeout_seconds to tunnel_preshared Oct 12, 2023
@bryantbiggs bryantbiggs merged commit 21442a7 into terraform-aws-modules:master Oct 12, 2023
9 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 12, 2023
@semantic-release-bot
chore(release): version 3.7.1 [skip ci]
e14493c 
### [3.7.1](v3.7.0...v3.7.1) (2023-10-12)

### Bug Fixes

* Add `dpd_timeout_seconds` to `tunnel_preshared` ([#95](#95)) ([21442a7](21442a7))
@antonbabenko
Copy link
Member

This PR is included in version 3.7.1 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aramatev @antonbabenko @bryantbiggs