Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] yt-dlp versioning #3039

Closed
sadlerm4 opened this issue Jan 18, 2025 · 8 comments · Fixed by #3042
Closed

[Discussion] yt-dlp versioning #3039

sadlerm4 opened this issue Jan 18, 2025 · 8 comments · Fixed by #3042
Assignees

Comments

@sadlerm4
Copy link
Contributor

sadlerm4 commented Jan 18, 2025

The yt-dlp package in terra doesn't follow upstream versioning, causing confusion.

The current version in terrarawhide is 20240117~git.1643686 where the date reflects when the terra package was built, but not the date when upstream tagged a nightly release. This isn't an issue for other -nightly packages because they don't use the date as the version number upstream, but yt-dlp does, along with a timestamp.

There is also a serious issue where running yt-dlp --version from the current terra package built from the latest commit outputs the current stable release version number.

The current stable release of yt-dlp is 2025.01.15

The current nightly release of yt-dlp is 2025.01.16.232854

The current master release of yt-dlp is 2025.01.16.024033

Therefore an average user will be going wtf why is the terra package newer than upstream??!!111!!!??!!????!!!111!

In addition, calling the terra package yt-dlp-nightly is actually a misnomer, because it is built directly from latest commit, and not actually the same as upstream's own nightly release, which is built every 24 hours.

I suggest a few things:

  1. Sourcing the source code from https://github.com/yt-dlp/yt-dlp-master-builds instead
  2. Adhering to upstream's versioning
  3. Renaming this package to yt-dlp-master
@sadlerm4 sadlerm4 self-assigned this Jan 18, 2025
Copy link

linear bot commented Jan 18, 2025

@sadlerm4
Copy link
Contributor Author

@korewaChino @madonuko thoughts?

@korewaChino
Copy link
Member

what about yt-dlp-git?

@madonuko
Copy link
Member

we could use the older versioning scheme then (%ver^%date.%shortcommit)

using the master builds is not a bad idea either

@sadlerm4
Copy link
Contributor Author

what about yt-dlp-git?

i like that too, but the version number is still a problem.

either find a new versioning scheme that doesn't include the date, and also inject that into the code, or just follow the upstream master package

you can still call the terra package -git i guess

@sadlerm4
Copy link
Contributor Author

(%ver^%date.%shortcommit)

unfortunately in this case %ver = %date

%ver is 2025.01.16

with how update.rhai works, you would end up with 2025.01.16^20250107.1643686, which is absolutely horrible

@sadlerm4
Copy link
Contributor Author

if it's up to me i would just use the master builds, use upstream versioning, but call the package yt-dlp-git, and include in package description that it's built from yt-dlp-master

@madonuko
Copy link
Member

honestly up to you, I don't see a problem with the original versioning scheme but yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants