Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Change "collectionType" to "collection" #226

Open
FooterManDev opened this issue Jun 1, 2024 · 0 comments
Open

[Feature Request]: Change "collectionType" to "collection" #226

FooterManDev opened this issue Jun 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@FooterManDev
Copy link

FooterManDev commented Jun 1, 2024

Is your feature request related to a problem?

Not really,
This is really just a little thing that bothers me. I mistakenly used collectionType for the Item task, in a JSON Schema I made, which was improper.

In Quest JSON, the XP task uses collectionType as the field name, while the Item task uses collection as the field name, for setting how the task is completed. These should be the same name, as they do the exact same function.

Please disregard my original comment before the edit, I suck at reading.

Solution(s)

Rename the XP task's collectionType field to collection, for parity with the Item task.

Describe alternatives you've considered

Or, the other way around.

Mod Version

1.1.12

Mod Loader Version

20.1 - 47.2.0

Mod Loader

Forge

Additional context

@FooterManDev FooterManDev added the enhancement New feature or request label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant