Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV ExtJS Locale #217

Open
KaiVolland opened this issue Nov 10, 2016 · 0 comments
Open

CSV ExtJS Locale #217

KaiVolland opened this issue Nov 10, 2016 · 0 comments

Comments

@KaiVolland
Copy link
Member

KaiVolland commented Nov 10, 2016

We should change the key in the CSV from the view name to the viewmodel name and adapt the logic.

This has one simple reason:

If you use the viewmodel with the corresponding value in another view the translated string cannot be found as the view has another xtype. e.g:

Ext.define('MyApp.SuperWindow', {
    extend: 'Ext.window.Window',
    viewModel: 'superwindow',

    bind: {
        title: '{superwindowtitle}'
    },

    initComponent: function(){
        Ext.create('Ext.window.Window', {
            viewModel: this.getViewModel(),
            bind: {
                 title: '{superwindowtitle}'
            }
        })
    }
});

If there is the following value in our CSV MyApp.SuperWindow, config.data.superwindowtitle, "peter", "paul" we get an error with the Ext.window.Window as it doesn't appear in the CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant