-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToolPath and ToolPathSegment class #832
base: master
Are you sure you want to change the base?
Add ToolPath and ToolPathSegment class #832
Conversation
What are you planning to use these for? |
Primarily for tool path visualization in tesseract_qt and filtering operations in a larger task composer graph which removes unreachable waypoints, small segments and breaking up large segments at configuration flips. |
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 90.19% 90.20% +0.01%
==========================================
Files 234 238 +4
Lines 14127 14185 +58
==========================================
+ Hits 12742 12796 +54
- Misses 1385 1389 +4
|
be58dda
to
ee5325f
Compare
Sounds familiar... Why not just use a composite instruction of Cartesian waypoints or move instructions instead? Seems like that probably has all the information necessary to do what you're looking for without having to add and maintain a new set of classes |
Yea, I thought about that but was not sure. It would be good to meet and discuss. |
This adds two classes ToolPath and ToolPathSegment. These two classes provided additional information for traceability during filtering operations and integration into tesseract_qt rendering. @marip8 Would you have time to take a look at this PR?