Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tolerance size #535

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rjoomen
Copy link
Contributor

@rjoomen rjoomen commented Dec 2, 2024

With the new toleranced waypoints, the tolerance variable type was introduced as a fixed Matrix (effectively Vector6d), always requiring 6 values. Here and here, however, a resize was still attempted, leading to silent errors, except for debug builds, where Eigen asserted an error.

This PR changes the types to a VectorXd, bringing the behavior in line with the coefs, allowing either 1 or 6 values, and fixing the resize() assert.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.47%. Comparing base (f141bdd) to head (4d4f3b7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
- Coverage   84.49%   84.47%   -0.02%     
==========================================
  Files         233      233              
  Lines       15864    15870       +6     
==========================================
+ Hits        13404    13406       +2     
- Misses       2460     2464       +4     

see 2 files with indirect coverage changes

@Levi-Armstrong
Copy link
Contributor

@rjoomen What about just fixing the xml parsing code to check if the token size is 1 then create fixed size vector of 6 and if not 1 it must be of length 6 otherwise throw an exceptions? @marip8 Interested to hear your thoughts on this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants