Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #542

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (193db12) to head (9874a56).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   78.84%   78.84%           
=======================================
  Files         251      251           
  Lines       14833    14833           
=======================================
  Hits        11695    11695           
  Misses       3138     3138           

see 2 files with indirect coverage changes

@Levi-Armstrong
Copy link
Contributor Author

@johnwason Can you test this branch?

@johnwason
Copy link
Contributor

I fixed a few errors but am still getting C:\ws\tesseract_dev\vcpkg\installed\x64-windows-v142-release\include\boost/serialization/access.hpp(116): error C2039: 'serialize': is not a member of 'trajopt_common::SafetyMarginData'

@Levi-Armstrong
Copy link
Contributor Author

It looks like it getting past the build stage now.

@johnwason
Copy link
Contributor

Oh I left comments on the other PR. Yes the test that is failing is expected. It is the TesseractTaskComposerFactoryUnit.LoadAndExportPluginTest (Failed) error which is expected since trajopt_ifopt isn't being built.

@Levi-Armstrong Levi-Armstrong merged commit ad73309 into tesseract-robotics:master Dec 11, 2024
11 of 17 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/fix-windows-lha branch December 11, 2024 02:13
@Levi-Armstrong
Copy link
Contributor Author

@johnwason Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants