Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising JDK requirements #920

Closed
4 tasks done
tesshucom opened this issue Mar 20, 2021 · 2 comments
Closed
4 tasks done

Raising JDK requirements #920

tesshucom opened this issue Mar 20, 2021 · 2 comments
Assignees
Labels
in: jdk ssues in jdk. type: enhancement A general enhancement

Comments

@tesshucom
Copy link
Owner

tesshucom commented Mar 20, 2021

We have already announced that JDK 11 is the minimum requirement. The current Maven profile does not default to 11, so we'll change it.

  • Change profiler configuration
  • Check if the autobuilder of LGTM can run with JDK11. The autobuilder of CodeQL has been confirmed to work properly.
  • Delete unnecessary profiles. Assuming JDK11 or later, no version branching profile is required.
  • Change profiles.
  • [The site's web page] Change compilation procedure (v110.0.0 RELEASE #922)

This allows for officially incompatible code changes. Related #838.


Profiles

In theory, it's one...

<maven.compiler.release>11</maven.compiler.release>

-> It overrides the version referenced by Spring, so it is as follows.

<java.version>11</java.version>
<maven.compiler.release>${java.version}</maven.compiler.release>

A profile to specify the version was created to cover up the specification method that differs depending on the version of Maven&JDK. We can remove this now, but that may be too hurry. If the purpose is clear, it may be better to keep the current method.

  • We can specify it with -Djava.version option dynamically, but cannot define a available input range with pom. Verification of JDK 11 and later versions is very fast and the results will be replaced in a few months. The profile is verbose, but it can define at the time the active version that is available as a result of validation. POM too simple, it will be confusing.
  • Some of the source generation tools have similar references, as SpringBoot. There is no guarantee that simple pom description will be maintained in the future. By specifying the version from the outside via the profile, even if the internal version control becomes complicated, it can be absorbed (as it was done in JDK8-11).
@tesshucom tesshucom added type: enhancement A general enhancement in: jdk ssues in jdk. labels Mar 20, 2021
@tesshucom tesshucom added this to the jpsonic 110.0.0 milestone Mar 20, 2021
@tesshucom tesshucom pinned this issue Mar 20, 2021
@tesshucom tesshucom self-assigned this Mar 20, 2021
@tesshucom
Copy link
Owner Author

image

@tesshucom tesshucom mentioned this issue Mar 20, 2021
@tesshucom tesshucom unpinned this issue Mar 20, 2021
This was referenced Mar 20, 2021
@tesshucom tesshucom reopened this Mar 23, 2021
tesshucom added a commit that referenced this issue Mar 26, 2021
tesshucom added a commit that referenced this issue Mar 31, 2021
tesshucom added a commit that referenced this issue Apr 1, 2021
tesshucom added a commit that referenced this issue Apr 2, 2021
tesshucom added a commit that referenced this issue Apr 11, 2021
tesshucom added a commit that referenced this issue Apr 13, 2021
@tesshucom tesshucom reopened this Apr 14, 2021
tesshucom added a commit that referenced this issue Apr 14, 2021
 - Change default value of package to Jetty & JDK11
@tesshucom
Copy link
Owner Author

tesshucom commented Apr 14, 2021

Change default value of package to Jetty & JDK11. When compiling manually, tomcat will not be selectable unless you specify options.

tesshucom added a commit that referenced this issue Apr 14, 2021
 - Change default value of package to Jetty & JDK11
tesshucom added a commit that referenced this issue Apr 14, 2021
 - Change default value of package to Jetty & JDK11
tesshucom added a commit that referenced this issue Apr 15, 2021
 - Change default value of package to Jetty & JDK11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: jdk ssues in jdk. type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant