Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up main driver file #24

Open
hartmantis opened this issue Oct 1, 2013 · 4 comments
Open

Split up main driver file #24

hartmantis opened this issue Oct 1, 2013 · 4 comments
Milestone

Comments

@hartmantis
Copy link
Contributor

It's starting to get too big for one file.

@monsterzz
Copy link
Contributor

Hi there, I'm going to start new enhancement feature branche (user_data, especially cloudconfig). It seems that all of features doesn't fit to one file.

Do you have thoughts how we can split it up?

@hartmantis
Copy link
Contributor Author

My first thoughts were to split things up like Fog does already: a compute/connection class, a server class, network class, etc. But I haven't had time to really sit down and work on it.

@TerryHowe
Copy link

I can see the point of this, but it is only 280 or so lines of code. Think about any time you have a method name with a noun in it, you could make the noun the object. create_server should perhaps be server.create for instance. Generally, methods should have nouns in them unless you are associating 2 objects if you are going OO like perhaps server.attach_ip(ip)

@hartmantis
Copy link
Contributor Author

@TerryHowe Thanks for the input. As an "accidental developer", I appreciate any and all. Very true, it's not too bad right now. This is partly here as a reminder it'll only ever get worse and partly as a small refactoring exercise for when I next have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants