Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface Treatment attributes not yet appearing #31

Open
mdeagen opened this issue Sep 28, 2020 · 1 comment
Open

Surface Treatment attributes not yet appearing #31

mdeagen opened this issue Sep 28, 2020 · 1 comment

Comments

@mdeagen
Copy link

mdeagen commented Sep 28, 2020

The following SPARQL query

PREFIX nm: <http://nanomine.org/ns/>
PREFIX sio: <http://semanticscience.org/resource/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT * WHERE {
  ?sample a nm:PolymerNanocomposite ;
          sio:hasComponentPart [ sio:hasRole [ a nm:Filler ] ;
                                 sio:isSurroundedBy [ sio:hasRole [ a nm:SurfaceTreatment ] ;
                                                      a [ rdfs:label ?surf_treat ] ;
                                                      sio:hasAttribute ?surf_treat_attr]
                               ]
} 

returns an empty set. I believe @rashidsabbir addressed this issue recently (we discussed 8/30), pending a push to QA. Including the issue here so that it can be formally closed once the fix is tested and deployed.

@mdeagen
Copy link
Author

mdeagen commented Oct 8, 2020

Update on this: ManufacturerOrSourceName now appears as an attribute for Surface Treatment. There are other attributes that I would expect (graft density, polydispersity, etc), however these may require separate updates to the ontology/setlr.

PREFIX nm: <http://nanomine.org/ns/>
PREFIX sio: <http://semanticscience.org/resource/>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
SELECT DISTINCT ?surf_treat_attr WHERE {
  ?sample a nm:PolymerNanocomposite ;
          sio:hasComponentPart [ sio:hasRole [ a nm:Filler ] ;
                                 sio:isSurroundedBy [ sio:hasRole [ a nm:SurfaceTreatment ] ;
                                                      a [ rdfs:label ?surf_treat ] ;
                                                      sio:hasAttribute [ a ?surf_treat_attr] ]
                               ]
} 

Returns 1 result: http://nanomine.org/ns/ManufacturerOrSourceName

Recommend keeping issue open until these additional attributes are identified and addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant