Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections ignoring hints #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

OmegaDroid
Copy link
Contributor

Hi again,

I noticed another issue where related relay connections were ignoring optimization_hints due to the resolver being nested inside partials so I've updated it to search down the partials chain to find the hints.

@codecov-io
Copy link

codecov-io commented Oct 11, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (e6bede5) to head (3ebc788).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   93.54%   93.29%   -0.26%     
==========================================
  Files           6        6              
  Lines         310      313       +3     
==========================================
+ Hits          290      292       +2     
- Misses         20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berkcoker
Copy link

berkcoker commented Jan 18, 2021

^^ would be great if this was merged... @tfoxy

@k1wdel
Copy link

k1wdel commented Oct 27, 2021

we've implemented a similar solution to solve the same problem in our project. would be nice if it gets in 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants