Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Demo issues #17

Open
sondresj opened this issue Jul 3, 2019 · 0 comments
Open

Layout Demo issues #17

sondresj opened this issue Jul 3, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sondresj
Copy link
Contributor

sondresj commented Jul 3, 2019

  • The View Source link is broken (the blue github icon), set srcPath='Layout.tsx' on the DemoTitle
  • The property screenSize isn't a property the user needs to provide, the Layout component get's it from the withScreenSize HOC wrapped around it.

You could also add a text saying that this (the github page) is using the Layout, something along the lines of 'This page is using the Layout component, view the code using the Layout <Link href='https://github.com/tfso/react-tfso-components/blob/master/src/demo/Layout.tsx'>here</Link>'

Otherwise good work! 👍

@sondresj sondresj added the bug Something isn't working label Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants