From a7005195d8ee6441bc0013a0e42d79005f129579 Mon Sep 17 00:00:00 2001 From: Jordan Dominion Date: Mon, 19 Aug 2024 21:43:18 -0400 Subject: [PATCH] Strip Codecov checks entirely. We'll revisit after we see how it works after the v4 uploader change --- .github/workflows/scripts/rerunFlakyTests.js | 3 +-- .../Tgstation.Server.ReleaseNotes/Program.cs | 25 +------------------ 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/.github/workflows/scripts/rerunFlakyTests.js b/.github/workflows/scripts/rerunFlakyTests.js index e2dc2d3c73..f8e5078066 100644 --- a/.github/workflows/scripts/rerunFlakyTests.js +++ b/.github/workflows/scripts/rerunFlakyTests.js @@ -11,8 +11,7 @@ const CONSIDERED_STEP_PREFIXES = [ const CONSIDERED_JOBS = [ "Windows Live Tests", "Linux Live Tests", - "Build .deb Package", - "Upload Code Coverage" + "Build .deb Package" ]; async function getFailedJobsForRun(github, context, workflowRunId, runAttempt) { diff --git a/tools/Tgstation.Server.ReleaseNotes/Program.cs b/tools/Tgstation.Server.ReleaseNotes/Program.cs index c59f86fd19..46c887fd5f 100644 --- a/tools/Tgstation.Server.ReleaseNotes/Program.cs +++ b/tools/Tgstation.Server.ReleaseNotes/Program.cs @@ -60,7 +60,6 @@ static async Task Main(string[] args) var fullNotes = versionString.Equals("--generate-full-notes", StringComparison.OrdinalIgnoreCase); var nuget = versionString.Equals("--nuget", StringComparison.OrdinalIgnoreCase); var genToken = versionString.Equals("--token-output-file", StringComparison.OrdinalIgnoreCase); - var waitCodecov = versionString.Equals("--wait-codecov", StringComparison.OrdinalIgnoreCase); if ((!Version.TryParse(versionString, out var version) || version.Revision != -1) && !ensureRelease @@ -68,8 +67,7 @@ static async Task Main(string[] args) && !shaCheck && !fullNotes && !nuget - && !genToken - && !waitCodecov) + && !genToken) { Console.WriteLine("Invalid version: " + versionString); return 2; @@ -157,11 +155,6 @@ static async Task Main(string[] args) client.Credentials = new Credentials(githubToken); } - if (waitCodecov) - { - return await CodecovCheck(client, Int64.Parse(args[1])); - } - if (linkWinget) { if (args.Length < 2 || !Uri.TryCreate(args[1], new UriCreationOptions(), out var actionsUrl)) @@ -1678,21 +1671,5 @@ static void DebugAssert(bool condition, string message = null) else Debug.Assert(condition); } - - static async ValueTask CodecovCheck(IGitHubClient client, long runId) - { - var currentRun = await client.Actions.Workflows.Runs.Get(RepoOwner, RepoName, runId); - - bool foundRun = false; - for(int i = 0; i < 15 && !foundRun; ++i) - { - var allRuns = await client.Check.Run.GetAllForReference(RepoOwner, RepoName, currentRun.HeadSha); - foundRun = allRuns.CheckRuns.Any(x => x.CheckSuite.Id == currentRun.Id && x.Name == "codecov/project"); - if (!foundRun && i != 14) - await Task.Delay(TimeSpan.FromMinutes(1)); - } - - return foundRun ? 0 : 24398; - } } }