Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons steal focus and retain focus until another element takes it away #24

Open
Kapu1178 opened this issue Sep 22, 2024 · 2 comments
Open

Comments

@Kapu1178
Copy link

This issue has been present for a while, I think since the React change. The issue was covered up by a CSS change done in tgstation/tgstation@e5d9053#diff-67bab2695db349f88853de7a56a71a48ebf6dc3eb99d17b231583be8ebaa6b22

@ZeWaka
Copy link
Collaborator

ZeWaka commented Sep 23, 2024

i don't seem to experience these focus issues, though

@Kashargul
Copy link
Contributor

i don't seem to experience these focus issues, though

It's stylewise changed on tgui core to no longer have the button highlighted on focus. The question is more, do we want to introduce a mid way? I'm not sure if it's a good idea or not, to change back to the highlighting on focus again and blur on clicks whilst keeping it on tabs, so that keyboard users keep their last used button highlighted and shown as selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants