Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Patcher should validate files individually #100

Open
th3-z opened this issue Sep 26, 2019 · 1 comment
Open

[FEATURE] Patcher should validate files individually #100

th3-z opened this issue Sep 26, 2019 · 1 comment
Labels
backlog Low priority featrure requests enhancement New features, improvements to existing features
Milestone

Comments

@th3-z
Copy link
Owner

th3-z commented Sep 26, 2019

Is your feature request related to a problem? Please describe.
The patcher validates all files and exits if any fail, it should be possible to patch files that pass validation and skip the dirty files.

Describe the solution you'd like
Skip invalid files, patch valid ones. An info message should also be added to notify the user of what files have been skipped.

Describe alternatives you've considered
Redownloading clean files just to add another patch is possible but annoying.

Additional context
Many users have already modified their webadmin files manually and will just need the header change to alow kf2-ma detection.

@th3-z th3-z added the enhancement New features, improvements to existing features label Sep 26, 2019
@th3-z th3-z added this to the 0.1.4 milestone Sep 26, 2019
@th3-z th3-z self-assigned this Sep 26, 2019
@th3-z th3-z modified the milestones: 0.1.4, 0.1.5 Sep 27, 2019
@th3-z th3-z added the good first issue A good place to get started with development label Oct 6, 2019
@th3-z th3-z removed their assignment Oct 6, 2019
@th3-z
Copy link
Owner Author

th3-z commented Oct 13, 2019

Removing the milestone and backlogging. I don't think this is important, it only validates relevant files.

@th3-z th3-z removed this from the 0.1.5 milestone Oct 13, 2019
@th3-z th3-z added the backlog Low priority featrure requests label Oct 13, 2019
@th3-z th3-z removed the good first issue A good place to get started with development label May 31, 2020
@th3-z th3-z added this to the 0.1.7 milestone May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Low priority featrure requests enhancement New features, improvements to existing features
Projects
None yet
Development

No branches or pull requests

1 participant