Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot index Storable > v2.51 #244

Open
mschout opened this issue May 15, 2018 · 1 comment
Open

Cannot index Storable > v2.51 #244

mschout opened this issue May 15, 2018 · 1 comment

Comments

@mschout
Copy link
Contributor

mschout commented May 15, 2018

Pinto is unable to index the module Storable for versions > 2.51.

Looking into this, it seems that that the META provides for Storable has changed. In v2.51, Pinto was able to index this module, and there was only a META.yml at that time (no META.json).

The next release in metacpan is 3.05, which has a META.json, but it does not declare a provides section.

The next release is 3.08, and it declares provides file Storable_pm.PL
The rest of the releases (3.09 thorugh 3.11), have provides file __Storable__.pm

One way to fix this in Pinto is to add a workaround in Pinto::Schema::Result::Package::can_index() such as:

    # Workaround for Storable
    return 1 if $self->name eq 'Storable'
        and ($self->file eq 'Storable_pm.PL' or $self->file eq '__Storable__.pm');

I'll gladly submit a PR for this if this is the preferred way to handle this. I'm not well versed enough in the CPAN Meta Spec to know if what Storable is doing here is correct so not sure if it would be more appropriate to file this over there.

@fzipi
Copy link

fzipi commented Sep 12, 2019

Had a problem with Storable 3.15 and this small workaround worked perfectly. I think it deserves a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants