Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking update to store shard statefulsets #214

Open
craigfurman opened this issue Mar 22, 2021 · 1 comment
Open

Breaking update to store shard statefulsets #214

craigfurman opened this issue Mar 22, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@craigfurman
Copy link
Contributor

craigfurman commented Mar 22, 2021 •
edited
Loading

Store shards deployed before #199 was merged cannot easily be updated with the latest revision of kube-thanos, because of 2 changes made to StatefulSet.spec: volumeClaimTemplates, and selector. The error I'm seeing from Kubernetes is updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden.

This isn't a huge problem because of being able to jsonnet-patch around this, but was still a little time consuming to diagnose and fix, and I wonder if there's a reasonable place to document this to save future users the time.
@metalmatze
Copy link
Contributor

This is probably best to be put in the CHANGELOG.md and then to be announced by the time we publish a new release.

@kakkoyun kakkoyun added the documentation Improvements or additions to documentation label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kakkoyun @metalmatze @craigfurman