Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upgrade thanos-receive-router since the generated manifest include the version in the selector. #317

Open
codestation opened this issue Jan 29, 2024 · 1 comment

Comments

@codestation
Copy link

If the thanos version is updated in the jsonnet file and new manifests are generated, those cannot be used to upgrade to a new version as the thanos-receive-router uses the version as one of the labels in the selector. Those labels are inmutable so applying the deployment manifest will fail.

Workaround: delete the thanos-receive-router deployment before upgrading.

Fix: do not include the app.kubernetes.io/version label in the selector matchLabels.

@pharaujo
Copy link

I believe this issue was fixed by #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants