Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable new arch #25

Merged
merged 1 commit into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
include:
- { target: linux-64, os: ubuntu-latest }
- { target: osx-arm64, os: macos-latest }
- { target: linux-aarch64, os: ubuntu-24.04-arm }
fail-fast: false

runs-on: ${{ matrix.os }}
Expand All @@ -29,7 +30,11 @@ jobs:

- name: Install magic
run: |
curl -ssL https://magic.modular.com | bash
if [[ ${{ matrix.target }} == "linux-aarch64" ]]; then
bash scripts/install_magic_aarch64.sh
else
curl -ssL https://magic.modular.com | bash
fi

- name: Build package for target platform
env:
Expand All @@ -42,7 +47,11 @@ jobs:

# Temporary method to fetch the rattler binary.
RATTLER_BINARY="rattler-build-aarch64-apple-darwin"
if [[ $TARGET_PLATFORM == "linux-64" ]]; then RATTLER_BINARY="rattler-build-x86_64-unknown-linux-musl"; fi
if [[ $TARGET_PLATFORM == "linux-64" ]]; then
RATTLER_BINARY="rattler-build-x86_64-unknown-linux-musl"
elif [[ $TARGET_PLATFORM == "linux-aarch64" ]]; then
RATTLER_BINARY="rattler-build-aarch64-unknown-linux-musl"
fi
curl -SL --progress-bar https://github.com/prefix-dev/rattler-build/releases/latest/download/${RATTLER_BINARY} -o rattler-build
chmod +x rattler-build
export PATH="$PATH:$(pwd)"
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: tests
name: Run Tests

on:
pull_request:
Expand All @@ -10,11 +10,13 @@ permissions:

jobs:
test:
name: with ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os: ["ubuntu-latest", "macos-latest"]
include:
- { target: linux-64, os: ubuntu-latest }
- { target: osx-arm64, os: macos-latest }
- { target: linux-aarch64, os: ubuntu-24.04-arm }
fail-fast: false

runs-on: ${{ matrix.os }}
timeout-minutes: 5
Expand All @@ -29,7 +31,11 @@ jobs:

- name: Install magic
run: |
curl -ssL https://magic.modular.com | bash
if [[ ${{ matrix.target }} == "linux-aarch64" ]]; then
bash scripts/install_magic_aarch64.sh
else
curl -ssL https://magic.modular.com | bash
fi

- name: Run tests
run: |
Expand Down
Loading
Loading