Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenCV dependency #32

Open
thaytan opened this issue Mar 17, 2021 · 2 comments
Open

Remove OpenCV dependency #32

thaytan opened this issue Mar 17, 2021 · 2 comments

Comments

@thaytan
Copy link
Owner

thaytan commented Mar 17, 2021

A few OpenCV-supplied functions are critical to the positional tracking, but not many. The main one is RANSAC PnP + Levenberg-Marquardt pose refinement. That could be rewritten based on the integrated Lambatwist P3P implementation.

The others that need replacing are for projecting 3D LED positions to 2D, and undistorting/correcting blobs in captured frames to compensate for lens distortion. Both should be fairly easy to extract from OpenCV or reimplement.

@gadLinux
Copy link

Why? Just in case you can do it better has some sense. But they are implemented and correctly. Let's use them

@thaytan
Copy link
Owner Author

thaytan commented Oct 16, 2023

just because it's a big dependency and the tracking only needs a couple of small functions from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants